Description

Wrap the Node.js process with the tini init wrapper. This enables proper kernel signal handling inside the container, removing the need for forceful shutdowns (e.g. $ docker ps; docker kill <container-id>).

This adds 96kB to the image size.

We may later be able to remove src/server/shutdown.js if the Babel issue is resolved (it's been a number of years). Though, it might serve has a failure handling in the event we miss something that keeps Node.js running (e.g. a setInterval without .unref()).

Motivation and Context

Node.js was not designed to run as PID 1 which leads to unexpected behaviour when running inside of Docker. For example, a Node.js process running as PID 1 will not respond to SIGINT (CTRL-C) and similar signals. ...
You can...include Tini directly in your Dockerfile, ensuring your process is always started with an init wrapper.

https://github.com/nodejs/docker-node/blob/main/docs/BestPractices.md#handling-kernel-signals

How Has This Been Tested?

I've built the image locally, used it via @americanexpress/one-app-runner (npm start -- --offline --docker-image=sha256:...) and upon CTRL+C the container stops (due to the Node.js process ending).

Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (adding or updating documentation)
• Dependency update
• Security update

Checklist:

• My change requires a change to the documentation and I have updated the documentation accordingly.
• These changes should be applied to a maintenance branch. (this is that PR, see fix(server): handle kernel signals by including tini #1387)
• This change requires cross browser checks.
• Performance tests should be ran against the server prior to merging.
• This change impacts caching for client browsers.
• This change impacts HTTP headers.
• This change adds additional environment variable requirements for One App users.
• I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

Don't have to wait 10,000ms for the shutdown check to run. Should also be more graceful and faster shutdowns in production.